chore(deps): bump cooklang-language-server to 0.2.4#373
Merged
Conversation
0.2.4 stops enabling cooklang's bundled_units feature, which it never used. Before #371 that would have silently changed cook recipe output, because we were relying on the language server to turn bundled_units on for us via feature unification. We now declare it ourselves, so this bump is a no-op for recipe output - snapshots are unchanged. Refs #366
ReviewReviewed the diff — this is about as clean as a dependency bump PR gets. Code quality / correctness
Security
Performance
Test coverage
No blocking issues. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up cooklang/cooklang-language-server#9, which stops the language server enabling
cooklang'sbundled_unitsfeature — it only parses and diagnoses, and never used the unit database.Why this is the interesting one
Before #371, this bump would have silently broken
cook recipe.We were getting
bundled_unitspurely by accident: we never declared it, and it reached us through cargo feature unification becausecooklang-language-serverdepended oncooklangwith default features. Take that away — exactly what the upstream fix does — and recipe output changes underneath you:"quantity": { - "scalable": true, - "unit": "cups", + "scalable": false, + "unit": "c",No warning, no compile error. Just different output.
Since #371 declares
bundled_unitson our owncooklangdependency, where it is actually used, this bump is a no-op for behaviour:cargo tree -e features -i cooklang—bundled_unitsstill enabledcargo test— 13 suites pass, snapshots unchanged (recipe output byte-identical)That is the whole point of #371, demonstrated.
Crate count
Unchanged at 396. We genuinely want the unit database, so the
toml/syn/prettyplease/quotecodegen chain stays — the upstream change stops it being forced on consumers who do not want it, which is a win for everyone else depending on the language server, not for us.Verification (CI toolchain, 1.97)
cargo clippy --all-targets -- -D warnings— 0 issuescargo fmt --check— cleancargo test— 13 suites passRefs #366